Paths

Table of Contentst

Differential D25849

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data
ClosedPublic
Actions

Authored by aklapper on Thu, Dec 5, 22:38.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data

Commits

rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data

Summary

Do not throw an exception when passing bogus parameters to hovercards but properly handle the missing array index by setting $object_phid to null.
In consequence, see a proper hovercard correctly displaying Unknown Object (????) instead of an exception.

Closes T15969

Test Plan

Go to http://phorge.localhost/search/hovercard/?cards={"whatever":{"whatever":"foobar"}} or http://phorge.localhost/?__path__=%2fsearch%2fhovercard%2f&cards={%22whatever%22:{%22whatever%22:%22foobar%22}} and see a nice Unknown Object (????) instead of an ugly exception
Go to http://phorge.localhost/search/hovercard/?cards={%22PHID-TASK-12345678%2F%22%3A{%22objectPHID%22%3A%22PHID-TASK-12345678%22%2C%22contextPHID%22%3Anull}} (make sure to use a valid task PHID) and still see a correct hovercard rendered

Diff Detail

Repository

Branch

T15969hovercards (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1645
Build 1645: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, Dec 5, 22:38

Owners added a reviewer: O1: Blessed Committers.Thu, Dec 5, 22:38

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Dec 5, 22:38

aklapper requested review of this revision.Thu, Dec 5, 22:38

Harbormaster completed remote builds in B1645: Diff 2561.Thu, Dec 5, 22:38

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

...like line 105 :)

This revision is now accepted and ready to land.Thu, Dec 5, 22:57

Right... one day I may get used to all those Phorge shortcuts, thanks

Harbormaster completed remote builds in B1648: Diff 2564.Fri, Dec 6, 11:58

Double slam-accept

Closed by commit rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data. · Explain WhyMon, Dec 9, 11:00

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

3 lines

2%

Loading...

O1: Blessed Committers

Diff 2561

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...