Paths

Table of Contentst

-
src/applications/search/controller/
-
applications/
-
search/
-
controller/
1/1
PhabricatorSearchHovercardController.php

Differential D25849

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data
ClosedPublic
Actions

Authored by aklapper on Dec 5 2024, 22:38.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15969: Hovercards "RuntimeException: Undefined index: objectPHID" when passing bogus data

Commits

rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data

Summary

Do not throw an exception when passing bogus parameters to hovercards but properly handle the missing array index by setting $object_phid to null.
In consequence, see a proper hovercard correctly displaying Unknown Object (????) instead of an exception.

Closes T15969

Test Plan

Go to http://phorge.localhost/search/hovercard/?cards={"whatever":{"whatever":"foobar"}} or http://phorge.localhost/?__path__=%2fsearch%2fhovercard%2f&cards={%22whatever%22:{%22whatever%22:%22foobar%22}} and see a nice Unknown Object (????) instead of an ugly exception
Go to http://phorge.localhost/search/hovercard/?cards={%22PHID-TASK-12345678%2F%22%3A{%22objectPHID%22%3A%22PHID-TASK-12345678%22%2C%22contextPHID%22%3Anull}} (make sure to use a valid task PHID) and still see a correct hovercard rendered

Diff Detail

Repository

rP Phorge

Branch

T15969hovercards (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1645
Build 1645: arc lint + arc unit

Event Timeline

aklapper created this revision.Dec 5 2024, 22:38

Owners added a reviewer: O1: Blessed Committers.Dec 5 2024, 22:38

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 5 2024, 22:38

aklapper requested review of this revision.Dec 5 2024, 22:38

Harbormaster completed remote builds in B1645: Diff 2561.Dec 5 2024, 22:38

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

...like line 105 :)

This revision is now accepted and ready to land.Dec 5 2024, 22:57

Right... one day I may get used to all those Phorge shortcuts, thanks

Harbormaster completed remote builds in B1648: Diff 2564.Dec 6 2024, 11:58

Double slam-accept

Closed by commit rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data. · Explain WhyDec 9 2024, 11:00

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

3 lines

O1: Blessed Committers

Diff 2561

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Show First 20 Lines • Show All 323 Lines • ▼ Show 20 Lines	private function getStandardDateFormat($date) {

if (isset($colloquial[$normalized])) {		if (isset($colloquial[$normalized])) {
return $colloquial[$normalized];		return $colloquial[$normalized];
}		}

// If this looks like an epoch timestamp, prefix it with "@" so that		// If this looks like an epoch timestamp, prefix it with "@" so that
// DateTime() reads it as one. Assume small numbers are a "Ymd" digit		// DateTime() reads it as one. Assume small numbers are a "Ymd" digit
// string instead of an epoch timestamp for a time in 1970.		// string instead of an epoch timestamp for a time in 1970.
		if ($date) {
		valerio.bozzolanUnsubmitted Done Inline Actions Thanks! P.S. I see that Phorge also usually do a short-circuit if(!$date) { return null; } Maybe useful also for less indentations, easier git blame (not a blocking comment - just tip) valerio.bozzolan: Thanks! P.S. I see that Phorge also usually do a short-circuit ```lang=php if(!$date) {…
if (ctype_digit($date) && ($date > 30000000)) {		if (ctype_digit($date) && ($date > 30000000)) {
$date = '@'.$date;		$date = '@'.$date;
}		}

$separator = $this->getFormatSeparator();		$separator = $this->getFormatSeparator();
$parts = preg_split('@[,./:-]@', $date);		$parts = preg_split('@[,./:-]@', $date);
return implode($separator, $parts);		return implode($separator, $parts);
}		}
		return null;
		}

private function getStandardTimeFormat($time) {		private function getStandardTimeFormat($time) {
$colloquial = array(		$colloquial = array(
'crack of dawn' => '5:00 AM',		'crack of dawn' => '5:00 AM',
'dawn' => '6:00 AM',		'dawn' => '6:00 AM',
'early' => '7:00 AM',		'early' => '7:00 AM',
'morning' => '8:00 AM',		'morning' => '8:00 AM',
'elevenses' => '11:00 AM',		'elevenses' => '11:00 AM',
Show All 21 Lines

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus dataClosedPublicActions