Differential D25842

Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception"
ClosedPublic
Actions

Authored by aklapper on Dec 2 2024, 00:28.

Tags

None

Referenced Files

	F2866384: D25842.1736628300.diff
	Fri, Jan 10, 20:45

	F2865852: D25842.1736611832.diff
	Fri, Jan 10, 16:10

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated
T15963: LDAP over TLS is broken

Commits

rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…

Summary

Revert commit 700090917af6dd2e27c9fd82269797b6ec5def59 per T15963.

Fixes T15963
Opens T15724

Test Plan

N/A.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Dec 2 2024, 00:28

Owners added a reviewer: O1: Blessed Committers.Dec 2 2024, 00:28

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 2 2024, 00:28

aklapper requested review of this revision.Dec 2 2024, 00:28

Harbormaster completed remote builds in B1636: Diff 2546.Dec 2 2024, 00:28

valerio.bozzolan accepted this revision.Dec 2 2024, 06:47

This revision is now accepted and ready to land.Dec 2 2024, 06:47

valerio.bozzolan edited the summary of this revision. (Show Details)Dec 2 2024, 06:48

valerio.bozzolan added a task: T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Closed by commit rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…. · Explain WhyDec 2 2024, 09:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

adapter/

PhutilLDAPAuthAdapter.php

9 lines

O1: Blessed Committers

Diff 2547

src/applications/auth/adapter/PhutilLDAPAuthAdapter.php

Loading...