Differential D25842

Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception"
ClosedPublic
Actions

Authored by aklapper on Mon, Dec 2, 00:28.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated
T15963: LDAP over TLS is broken

Commits

rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…

Summary

Revert commit 700090917af6dd2e27c9fd82269797b6ec5def59 per T15963.

Fixes T15963
Opens T15724

Test Plan

N/A.

Diff Detail

Repository

rP Phorge

Branch

D25792revert (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1636
Build 1636: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Dec 2, 00:28

Owners added a reviewer: O1: Blessed Committers.Mon, Dec 2, 00:28

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Dec 2, 00:28

aklapper requested review of this revision.Mon, Dec 2, 00:28

Harbormaster completed remote builds in B1636: Diff 2546.Mon, Dec 2, 00:28

valerio.bozzolan accepted this revision.Mon, Dec 2, 06:47

This revision is now accepted and ready to land.Mon, Dec 2, 06:47

valerio.bozzolan edited the summary of this revision. (Show Details)Mon, Dec 2, 06:48

valerio.bozzolan added a task: T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Closed by commit rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…. · Explain WhyMon, Dec 2, 09:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

adapter/

PhutilLDAPAuthAdapter.php

9 lines

O1: Blessed Committers

Diff 2546

View Options

src/applications/auth/adapter/PhutilLDAPAuthAdapter.php

Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception"ClosedPublicActions