Page MenuHomePhorge

Fix exception handling in ConpherenceViewController::handleRequest()
ClosedPublic

Authored by aklapper on Aug 15 2024, 13:58.

Details

Summary

It is only possible throw an Exception class. Aphront400Response is not an Exception class but a Phobject.
Thus return it, like the Aphront404Responses within the same method.

Test Plan

Check parent classes; run static code analysis. Hack the code to force that return,
and successfully obtain an HTTP 400 status code page.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable