Remove unused PhutilConsoleProgressSink::getWidth()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:34.

Tags

None

Referenced Files

	F2995584: D25782.1740345936.diff
	Sat, Feb 22, 21:25

	F2995583: D25782.1740345935.diff
	Sat, Feb 22, 21:25

	F2995465: D25782.1740342463.diff
	Sat, Feb 22, 20:27

	F2981923: D25782.1739943084.diff
	Tue, Feb 18, 05:31

	F2951569: D25782.1738895318.diff
	Thu, Feb 6, 02:28

	F2949571: D25782.1738631217.diff
	Mon, Feb 3, 01:06

	F2947848: D25782.1738505077.diff
	Sat, Feb 1, 14:04

	F2946902: D25782.1738429691.diff
	Fri, Jan 31, 17:08

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth()

Summary

This private function was added in https://secure.phabricator.com/rPHU71e8d7a4cf8e9f56b1427c27b3684ae17a3ea7c7 and has never been used.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 16 2024, 06:34

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:34

aklapper requested review of this revision.Aug 16 2024, 06:34

Harbormaster completed remote builds in B1532: Diff 2377.Aug 16 2024, 06:34

valerio.bozzolan accepted this revision.Sep 4 2024, 09:37

valerio.bozzolan added inline comments.

src/progress/PhutilConsoleProgressSink.php
27	I think the mentioned method was probably part of this TODO, to draw a progress bar with the size of the screen. So maybe it's OK to drop until completed.

This revision is now accepted and ready to land.Sep 4 2024, 09:37

Closed by commit rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth(). · Explain WhySep 4 2024, 09:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().

Revision Contents
Changeset List

Path

Size

Packages

src/

progress/

PhutilConsoleProgressSink.php

11 lines

O1: Blessed Committers

Diff 2444

View Options

src/progress/PhutilConsoleProgressSink.php

Remove unused PhutilConsoleProgressSink::getWidth()ClosedPublicActions