Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
ClosedPublic

Authored by aklapper on Sep 4 2024, 08:13.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Refs T15936

Test Plan

Read the code; compare to D25186.

Diff Detail

Repository
rP Phorge
Branch
T15936
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1578
Build 1578: arc lint + arc unit