Paths

Table of Contentst

Differential D25795

Replace invalid PHPDoc @return type boolean with bool
ClosedPublic
Actions

Authored by aklapper on Aug 21 2024, 12:06.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool

Summary

@return boolean is not a valid type thus use @return bool.

Test Plan

None.

Diff Detail

Repository

rP Phorge

Branch

phpdocBooleanBool

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1552
Build 1552: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 21 2024, 12:06

Owners added a reviewer: O1: Blessed Committers.Aug 21 2024, 12:06

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 21 2024, 12:06

aklapper requested review of this revision.Aug 21 2024, 12:06

Harbormaster completed remote builds in B1552: Diff 2403.Aug 21 2024, 12:06

yesyes

This revision is now accepted and ready to land.Aug 21 2024, 21:54

Closed by commit rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool. · Explain WhyAug 22 2024, 09:17

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

infrastructure/

parser/

PhutilURIHelper.php

2 lines

100%

O1: Blessed Committers

Diff 2403

View Options

src/infrastructure/parser/PhutilURIHelper.php

Replace invalid PHPDoc @return type boolean with boolClosedPublicActions