Remove unused *ParallelQueries() database connection methods
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 15:08.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15919: AphrontMySQLDatabaseConnection calls external method fb_parallel_query()

Commits

rP30c47690ffe3: Remove unused *ParallelQueries() database connection methods

Summary

executeParallelQueries() is never called as supportsParallelQueries() returns false both in AphrontDatabaseConnection and AphrontMySQLDatabaseConnection.
Thus remove this unused code which was intentionally meant for HHVM which does not support PHP>=7 anyway.

P.S. Dear Facebook, if you are using this, let us know. We don't want to hurt your legacy Phabricator installation.

Closes T15919

Test Plan

Grep for both functions.

Diff Detail

Repository

rP Phorge

Branch

fbConnectmysql

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/infrastructure/storage/future/QueryFuture.php:47	XHP86	Unsafe Usage of Dynamic String

Unit

Tests Passed

Build Status

Buildable 1540
Build 1540: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 15:08

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 15:08

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 15:08

aklapper requested review of this revision.Aug 16 2024, 15:08

Harbormaster completed remote builds in B1540: Diff 2385.Aug 16 2024, 15:08

valerio.bozzolan edited the summary of this revision. (Show Details)Sep 5 2024, 13:13

This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.

From the point of view of Phorge, your edit is appreciated. Thanks.

From the point of view of other unknown people: we don't know what you are doing, so, if you care about this dead code, please just chat a bit with us in Phorge 🌈 we don't bite.

lgtm