Differential D25788

Remove unused PHUICalendarMonthView::getMaxDailyEventsForWeek()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 07:18.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP66bd13b193b6: Remove unused PHUICalendarMonthView::getMaxDailyEventsForWeek()

Summary

Call to this private function was removed in https://we.phorge.it/rPaee9d88c17e25b924ecd5293691cc6fe38d6c7d9.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

unusedMethods5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1538
Build 1538: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 07:18

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 07:18

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 07:18

aklapper requested review of this revision.Aug 16 2024, 07:18

Harbormaster completed remote builds in B1538: Diff 2383.Aug 16 2024, 07:18

lgtm

This revision is now accepted and ready to land.Aug 18 2024, 12:45

Closed by commit rP66bd13b193b6: Remove unused PHUICalendarMonthView::getMaxDailyEventsForWeek(). · Explain WhyAug 18 2024, 12:57

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP66bd13b193b6: Remove unused PHUICalendarMonthView::getMaxDailyEventsForWeek().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

view/

phui/

calendar/

PHUICalendarMonthView.php

12 lines

O1: Blessed Committers

Diff 2383

View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Remove unused PHUICalendarMonthView::getMaxDailyEventsForWeek()ClosedPublicActions