Differential D25785

Remove unused HeraldAdapter:buildTokenizerFieldValue()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:53.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPcf5abd9e4b6b: Remove unused HeraldAdapter:buildTokenizerFieldValue()

Summary

This private function was added in https://we.phorge.it/rP715233fb611569b86f8fd4d8339a7e514c749d69.
Its last use was removed in https://we.phorge.it/rP776caa507b15ef013d3d623d30b294181e2b4c11.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

unusedMethods2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1535
Build 1535: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 06:53

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:53

Harbormaster completed remote builds in B1535: Diff 2380.Aug 16 2024, 06:53

aklapper requested review of this revision.Aug 16 2024, 06:53

sgtm

This revision is now accepted and ready to land.Aug 20 2024, 06:56

Closed by commit rPcf5abd9e4b6b: Remove unused HeraldAdapter:buildTokenizerFieldValue(). · Explain WhyAug 20 2024, 08:09

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPcf5abd9e4b6b: Remove unused HeraldAdapter:buildTokenizerFieldValue().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

herald/

adapter/

HeraldAdapter.php

10 lines

O1: Blessed Committers

Diff 2380

View Options

src/applications/herald/adapter/HeraldAdapter.php

Remove unused HeraldAdapter:buildTokenizerFieldValue()ClosedPublicActions