Differential D25782

Remove unused PhutilConsoleProgressSink::getWidth()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:34.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth()

Summary

This private function was added in https://secure.phabricator.com/rPHU71e8d7a4cf8e9f56b1427c27b3684ae17a3ea7c7 and has never been used.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

Branch

unusedMethods

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1532
Build 1532: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 06:34

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:34

aklapper requested review of this revision.Aug 16 2024, 06:34

Harbormaster completed remote builds in B1532: Diff 2377.Aug 16 2024, 06:34

valerio.bozzolan accepted this revision.Sep 4 2024, 09:37

valerio.bozzolan added inline comments.

src/progress/PhutilConsoleProgressSink.php
27	I think the mentioned method was probably part of this TODO, to draw a progress bar with the size of the screen. So maybe it's OK to drop until completed.

This revision is now accepted and ready to land.Sep 4 2024, 09:37

Closed by commit rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth(). · Explain WhySep 4 2024, 09:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

progress/

PhutilConsoleProgressSink.php

11 lines

4%

Loading...

O1: Blessed Committers

Diff 2377

src/progress/PhutilConsoleProgressSink.php

Loading...