Page MenuHomePhorge

Fix $boot_length comparison in PhagePHPAgentBootloader
ClosedPublic

Authored by aklapper on Aug 11 2024, 20:48.
Tags
None
Referenced Files
F2995571: D25770.1740345922.diff
Sat, Feb 22, 21:25
F2995562: D25770.1740345914.diff
Sat, Feb 22, 21:25
F2995479: D25770.1740342928.diff
Sat, Feb 22, 20:35
F2981930: D25770.1739943090.diff
Tue, Feb 18, 05:31
F2980071: D25770.1739874841.diff
Mon, Feb 17, 10:34
F2963968: D25770.1739263849.diff
Mon, Feb 10, 08:50
F2963782: D25770.1739228536.diff
Sun, Feb 9, 23:02
F2962104: D25770.1739173047.diff
Sun, Feb 9, 07:37

Details

Summary

$boot_length = strlen($boot_sequence->toString()) returns an int and strlen() expects a string as a parameter. Thus calling if (strlen($boot_length) > 8192) afterwards to get the string length of an integer makes no sense.

Test Plan

Read the code.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable