Paths

Table of Contentst

Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()
ClosedPublic
Actions

Authored by aklapper on Aug 15 2024, 14:03.

Tags

None

Referenced Files

	F2993250: D25781.1740278713.diff
	Sat, Feb 22, 02:45

	F2993242: D25781.1740278289.diff
	Sat, Feb 22, 02:38

	F2981924: D25781.1739943084.diff
	Tue, Feb 18, 05:31

	F2932616: D25781.1737740142.diff
	Jan 23 2025, 17:35

	F2932611: D25781.1737740139.diff
	Jan 23 2025, 17:35

	F2932495: D25781.1737737239.diff
	Jan 23 2025, 16:47

	F2920129: D25781.1737545701.diff
	Jan 21 2025, 11:35

	F2904811: D25781.1737334066.diff
	Jan 19 2025, 00:47

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()

Summary

Add an additional check that $empty_exception is not null before try to throw it.

Test Plan

Read the previous code; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

diffusionCommitQueryLogic

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1531
Build 1531: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 15 2024, 14:03

Owners added a reviewer: O1: Blessed Committers.Aug 15 2024, 14:03

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 15 2024, 14:03

aklapper requested review of this revision.Aug 15 2024, 14:03

Harbormaster completed remote builds in B1531: Diff 2374.Aug 15 2024, 14:03

sgtm

This revision is now accepted and ready to land.Aug 15 2024, 15:16

Closed by commit rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage(). · Explain WhyAug 15 2024, 18:24

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

2 lines

O1: Blessed Committers

Diff 2374

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()ClosedPublicActions