Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngine
Needs ReviewPublic
Actions

Authored by aklapper on Aug 14 2024, 12:58.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

Parent PhabricatorProfileMenuEngine::newNoContentView expects one parameter being an array of strings. Thus do not pass two string parameters.

Followup to rPf8b8d88

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Branch

portalProfileMenu

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1526
Build 1526: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 14 2024, 12:58

Owners added a reviewer: O1: Blessed Committers.Aug 14 2024, 12:58

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 14 2024, 12:58

aklapper requested review of this revision.Aug 14 2024, 12:58

Harbormaster completed remote builds in B1526: Diff 2369.Aug 14 2024, 12:58

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

dashboard/

engine/

PhabricatorDashboardPortalProfileMenuEngine.php

5 lines

O1: Blessed Committers

Diff 2369

View Options

src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php

Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngineNeeds ReviewPublicActions