Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in DivinerFindController
ClosedPublic

Authored by aklapper on Aug 11 2024, 15:00.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerFindController.php:40]

Closes T15910

Test Plan

Go to this (or any other Diviner Find URL not passing a type URI parameter): now it works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML

Go to this (or any other Diviner Find URL passing a type URI parameter): it still works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class

Diff Detail

Repository
rP Phorge
Branch
T15910divinerStrlen
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1512
Build 1512: arc lint + arc unit