Arcanist Text Linter: do not break the "ics" special format
AbandonedPublic
Actions

Authored by valerio.bozzolan on Aug 7 2024, 10:08.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15905: Linter: do not break "ics" files

Summary

Avoid these unexpected lint errors on .ics files:

Error (TXT1) DOS Newlines You must use ONLY Unix linebreaks ("\n") in source code.
Error (TXT5) Bad Charset Source code should contain only ASCII bytes with ordinal decimal values...

Also, their related auto-fixers (that break the format) are now not triggered anymore.

Specifications about newlines:

Closes T15905

Test Plan

Put an .ics file on Phorge. No weird lint errors (for example on feature T15564).

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1503
Build 1503: arc lint + arc unit

	Time	Test
	72 ms	ArcanistPhpcsLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "basics.lint-test". MISSING MESSAGES Message with severity "error" at "2:1"
	6 ms	ArcanistChmodLinterTestCase::testLinter 5 assertion(s) passed.
	0 ms	ArcanistClosureLinterTestCase::testVersion 1 assertion(s) passed.
	0 ms	ArcanistCpplintLinterTestCase::testVersion 1 assertion(s) passed.
	11 ms	ArcanistFilenameLinterTestCase::testLinter 5 assertion(s) passed.
		View Full Test Results (1 Failed · 21 Passed · 31 Skipped)