PHPStan complains about Access to private property $exception of parent class Future and Access to private property $result of parent class Future in QueryFuture.
Thus call the corresponding public functions provided by Future instead.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP6d5cde8e1cbc: Fix accessing private parent class properties in QueryFuture
Run static code analysis; read the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phutilFuturePrivateVars
- Lint
Lint Errors Severity Location Code Message Error src/infrastructure/storage/future/QueryFuture.php:47 XHP86 Unsafe Usage of Dynamic String - Unit
Tests Passed - Build Status
Buildable 1474 Build 1474: arc lint + arc unit
Event Timeline
Comment Actions
Seems good thanks. It seems we can also have it shorter with canResolve() 🤔
https://we.phorge.it/source/arcanist/browse/master/src/future/Future.php$253-263
| src/infrastructure/storage/future/QueryFuture.php | ||
|---|---|---|
| 54 | Evaluate this instead | |