PhrictionDocumentTitleTransaction calls $this->renderHandleLink().
PhabricatorApplicationTransaction defines that method public function renderHandleLink($phid).
PhrictionDocumentTitleTransaction extends PhrictionDocumentVersionTransaction extends PhrictionDocumentTransactionType extends PhabricatorModularTransactionType extends Phobject. No PhabricatorApplicationTransaction in that ancestor tree. Thus this call will fail.
Thus replace renderHandleLink() with renderHandle() which accepts a PHID as its parameter (credits to mainframe98 for finding out).
Details
Details
- Reviewers
mainframe98 valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP6b9b0490ddf5: Fix call to undefined method PhrictionDocumentTitleTransaction…
Unclear how to trigger via the UI, so run static code analysis and read/grep the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phrictionTitleTrans
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1469 Build 1469: arc lint + arc unit
Event Timeline
Comment Actions
This doesn't seem correct. renderObject doesn't take any arguments. I suspect the intention was renderHandle, as that method takes a PHID, which the metadata key mentions.
| src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php | ||
|---|---|---|
| 50 | ||
Comment Actions
Ah, thanks, that makes more sense, indeed. (I dislike changes that have an unclear reproduction path.)
Comment Actions
Replace renderHandleLink() with renderHandle() and not renderObject(), as rightfully pointed out by mainframe98
Comment Actions
I haven't the foggiest how this transaction is supposed to use its stub variant; attempting to create a document at /w/parent/child causes an error about /w/parent/ being required.
Comment Actions
I agree about the mystery in the test plan. Anyway, easily test-able by replacing $this->getMetadataValue('stub:create:phid') with a PHID lol. Thaaaanks all.