Page MenuHomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
ClosedPublic

Authored by aklapper on Jul 28 2024, 14:44.
Tags
None
Referenced Files
F2994788: D25751.1740329435.diff
Sat, Feb 22, 16:50
F2977792: D25751.1739653334.diff
Fri, Feb 14, 21:02
F2977791: D25751.1739653333.diff
Fri, Feb 14, 21:02
F2977734: D25751.1739649501.diff
Fri, Feb 14, 19:58
F2977684: D25751.1739643832.diff
Fri, Feb 14, 18:23
F2963951: D25751.1739259308.diff
Mon, Feb 10, 07:35
F2876689: D25751.1736997431.diff
Jan 15 2025, 03:17
F2874781: D25751.1736962375.diff
Jan 14 2025, 17:32

Details

Summary

PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan

Run static code analysis; read/grep the codebase.

Diff Detail

Repository
rP Phorge
Branch
customFieldReadVal
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1468
Build 1468: arc lint + arc unit