PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.
Closes T15895
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15895: PhabricatorCustomField::readValueFromObject() should not return $this
- Commits
- rPaaff2415f981: Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
Run static code analysis; read/grep the codebase.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- customFieldReadVal
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1468 Build 1468: arc lint + arc unit