Method PhabricatorConfigConsoleController::newLibraryVersionTable() invoked with 1 parameter, 0 required.
Thus remove the parameter from its only call across the codebase.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP4e31cadb54d2: Remove unused parameter from PhabricatorConfigConsoleController…
Read the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- configLibVersionTable
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1455 Build 1455: arc lint + arc unit
Event Timeline
Comment Actions
Thanks.
I cannot imagine any situation where the incoming viewer from handleRequest(AphrontRequest $request) could be different from the implicit viewer from AphrontController#getViewer() ($this->getRequest()->getViewer()).
Also, practically, the objects are the same:
So I wonder why handleRequest(AphrontRequest $request) has such parameter. Maybe it should have no parameters and just rely on $this->getRequest(). But this is an unrelated story.
Safe change. Thanks