AphrontTypeaheadTemplateView::renderToken() is an undefined method,
and its result is stored in an orphan variable, and no child class
extends AphrontTypeaheadTemplateView defining a renderToken().
Thus remove its call from AphrontTypeaheadTemplateView::render().
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP0873b36569bf: Remove call to non-existing AphrontTypeaheadTemplateView::renderToken()
Read/grep the code in this class.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- aphrontTypeaheadTemplateViewRenderToken
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1421 Build 1421: arc lint + arc unit
Event Timeline
Comment Actions
Additional consideration under control: an external class may have extended AphrontTypeaheadTemplateView and defining a renderToken() there, and making this snippet operative (I'm not saying that it's a good practice, I'm saying that it would work). But this extreme corner case is not the case.
grep -FR 'renderToken(' .
./src/applications/search/compiler/PhutilSearchQueryCompiler.php: $result[] = $this->renderToken($token);
./src/applications/search/compiler/PhutilSearchQueryCompiler.php: $result[] = $this->renderToken($token);
./src/applications/search/compiler/PhutilSearchQueryCompiler.php: $result[] = $this->renderToken($token, $this->getStemmer());
./src/applications/search/compiler/PhutilSearchQueryCompiler.php: private function renderToken(
./src/view/control/AphrontTypeaheadTemplateView.php: $tokens[] = $this->renderToken($key, $value);The PhutilSearchQueryCompiler is completely unrelated 👍
Moreover the result is stored in an orphan variable. It may happen that this method could have desired rendering side-effects, but this is just not the case, per above. Thanks