Page MenuHomePhorge
Differential D25715

Fix property name typo in PhabricatorPDFIterator
ClosedPublic
Actions

Authored by aklapper on Jul 2 2024, 19:11.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator
Summary

$framgentKey has a typo.

Test Plan

Slowly spell the word "fragmentKey"; compare with the top of the file.

Diff Detail

Repository
rP Phorge
Branch
typoPhortunePdf
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1415
Build 1415: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 2 2024, 19:11
Owners added a reviewer: O1: Blessed Committers.Jul 2 2024, 19:11
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 2 2024, 19:11
aklapper requested review of this revision.Jul 2 2024, 19:11
Harbormaster completed remote builds in B1415: Diff 2207.Jul 2 2024, 19:11
valerio.bozzolan accepted this revision.Jul 12 2024, 09:50

sgtm

Seems that nothing internally accessed that method, and probably nothing externally. But we should probably keep that method since it's public. Thanks.

This revision is now accepted and ready to land.Jul 12 2024, 09:50
Closed by commit rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator. · Explain WhyJul 12 2024, 10:20
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
phortune/
pdf/
2 lines4%
Loading...
O1: Blessed Committers

Diff 2207

View Options

src/applications/phortune/pdf/PhabricatorPDFIterator.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0