Paths

Table of Contentst

Fix property name typo in PhabricatorPDFIterator
ClosedPublic
Actions

Authored by aklapper on Jul 2 2024, 19:11.

Tags

None

Referenced Files

	F3350318: D25715.1743765477.diff
	Thu, Apr 3, 11:17

	F3339331: D25715.1743617536.diff
	Tue, Apr 1, 18:12

	F3334375: D25715.1743548781.diff
	Mon, Mar 31, 23:06

	F3331443: D25715.1743507017.diff
	Mon, Mar 31, 11:30

	F3331221: D25715.1743503419.diff
	Mon, Mar 31, 10:30

	F3330902: D25715.1743496757.diff
	Mon, Mar 31, 08:39

	F3329548: D25715.1743476728.diff
	Mon, Mar 31, 03:05

	F3319730: D25715.1743314011.diff
	Sat, Mar 29, 05:53

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator

Summary

$framgentKey has a typo.

Test Plan

Slowly spell the word "fragmentKey"; compare with the top of the file.

Diff Detail

Repository

rP Phorge

Branch

typoPhortunePdf

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1415
Build 1415: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 2 2024, 19:11

Owners added a reviewer: O1: Blessed Committers.Jul 2 2024, 19:11

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 2 2024, 19:11

aklapper requested review of this revision.Jul 2 2024, 19:11

Harbormaster completed remote builds in B1415: Diff 2207.Jul 2 2024, 19:11

sgtm

Seems that nothing internally accessed that method, and probably nothing externally. But we should probably keep that method since it's public. Thanks.

This revision is now accepted and ready to land.Jul 12 2024, 09:50

Closed by commit rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator. · Explain WhyJul 12 2024, 10:20

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

phortune/

pdf/

PhabricatorPDFIterator.php

2 lines

O1: Blessed Committers

Diff 2207

View Options

src/applications/phortune/pdf/PhabricatorPDFIterator.php

Fix property name typo in PhabricatorPDFIteratorClosedPublicActions