Paths

Table of Contentst

Differential D25710

[STUB] Fix missing file attachment in Conpherence
AbandonedPublicDraft
Actions

Authored by valerio.bozzolan on Jul 1 2024, 12:07.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

Please ignore this change.

See this instead:

D25709: Fix missing file attachment in Conpherence

Test Plan

open a Conpherence chat or create a new one
drag and drop file in it and send the message
verify file is attached to the chat

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25705

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1399
Build 1399: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Jul 1 2024, 12:07

valerio.bozzolan held this revision as a draft.

Harbormaster completed remote builds in B1398: Diff 2187.Jul 1 2024, 12:07

valerio.bozzolan changed the visibility from "Public (No Login Required)" to "No One".Jul 1 2024, 12:14

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan removed a task: T15106: "Upload file" in remarkup text fields should attach by default .

restore original change

Harbormaster completed remote builds in B1399: Diff 2188.Jul 1 2024, 12:16

apply proposed change

Harbormaster completed remote builds in B1400: Diff 2189.Jul 1 2024, 12:17

valerio.bozzolan edited the summary of this revision. (Show Details)Jul 1 2024, 12:17

valerio.bozzolan changed the visibility from "No One" to "Public (No Login Required)".

valerio.bozzolan added inline comments.Jul 1 2024, 12:30

src/applications/transactions/constants/PhabricatorTransactions.php
50 ↗	(On Diff #2189)	Maybe a better name is `findOneByType()`

valerio.bozzolan mentioned this in D25709: Fix missing file attachment in Conpherence.Jul 1 2024, 12:30

valerio.bozzolan abandoned this revision.Jul 2 2024, 09:12

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

23 lines

O1: Blessed Committers

Diff 2188

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

[STUB] Fix missing file attachment in ConpherenceAbandonedPublicDraftActions