Page MenuHomePhorge
Differential D25710

[STUB] Fix missing file attachment in Conpherence
AbandonedPublicDraft
Actions

Authored by valerio.bozzolan on Jul 1 2024, 12:07.
Tags
None
Referenced Files
F3298006: D25710.1742995093.diff
Tue, Mar 25, 13:18
F3297599: D25710.1742986689.diff
Tue, Mar 25, 10:58
F3296279: D25710.1742970655.diff
Tue, Mar 25, 06:30
F3293151: D25710.1742908337.diff
Mon, Mar 24, 13:12
F3292602: D25710.1742896659.diff
Mon, Mar 24, 09:57
F3292295: D25710.1742891303.diff
Mon, Mar 24, 08:28
F3292011: D25710.1742885878.diff
Mon, Mar 24, 06:57
F3289563: D25710.1742849189.diff
Sun, Mar 23, 20:46
View All 32 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Please ignore this change.

See this instead:

D25709: Fix missing file attachment in Conpherence

Test Plan
  1. open a Conpherence chat or create a new one
  2. drag and drop file in it and send the message
  3. verify file is attached to the chat

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25705
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1398
Build 1398: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Jul 1 2024, 12:07
valerio.bozzolan held this revision as a draft.
Harbormaster completed remote builds in B1398: Diff 2187.Jul 1 2024, 12:07
valerio.bozzolan changed the visibility from "Public (No Login Required)" to "No One".Jul 1 2024, 12:14
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan removed a task: T15106: "Upload file" in remarkup text fields should attach by default .
valerio.bozzolan updated this revision to Diff 2188.Jul 1 2024, 12:16

restore original change

Harbormaster completed remote builds in B1399: Diff 2188.Jul 1 2024, 12:16
valerio.bozzolan updated this revision to Diff 2189.Jul 1 2024, 12:17

apply proposed change

Harbormaster completed remote builds in B1400: Diff 2189.Jul 1 2024, 12:17
valerio.bozzolan edited the summary of this revision. (Show Details)Jul 1 2024, 12:17
valerio.bozzolan changed the visibility from "No One" to "Public (No Login Required)".
valerio.bozzolan added inline comments.Jul 1 2024, 12:30
src/applications/transactions/constants/PhabricatorTransactions.php
50

Maybe a better name is findOneByType()

valerio.bozzolan mentioned this in D25709: Fix missing file attachment in Conpherence.Jul 1 2024, 12:30
valerio.bozzolan abandoned this revision.Jul 2 2024, 09:12

Revision Contents
Changeset List

PathSizePackages
src/
applications/
conpherence/
controller/
24 linesO1: Blessed Committers
transactions/
constants/
15 linesO1: Blessed Committers

Diff 2187

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0