Page MenuHomePhorge

Remove janky array copying workaround for IE8
Needs ReviewPublic

Authored by aklapper on Jun 29 2024, 18:10.
Tags
None
Referenced Files
F2991894: D25704.1740198708.diff
Fri, Feb 21, 04:31
F2991893: D25704.1740198708.diff
Fri, Feb 21, 04:31
F2990357: D25704.1740177336.diff
Thu, Feb 20, 22:35
F2982812: D25704.1739971909.diff
Tue, Feb 18, 13:31
F2982776: D25704.1739971820.diff
Tue, Feb 18, 13:30
F2981966: D25704.1739943127.diff
Tue, Feb 18, 05:32
F2978870: D25704.1739715353.diff
Sat, Feb 15, 14:15
F2964103: D25704.1739300000.diff
Mon, Feb 10, 18:53

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Internet Explorer 8 and earlier did not consider DOM NodeLists to be JS objects.
In different words: IE<9 did not support Array#slice on collections objects.
See for example https://stackoverflow.com/a/11113539

This reverts rP597c6c07f7120d253e83fa110db8842bfa05859f

Test Plan

Still: Load a diff in a web browser; see changes and do not get JS errors.

Diff Detail

Repository
rP Phorge
Branch
ie8nodelist
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1379
Build 1379: arc lint + arc unit