Page MenuHomePhorge

Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver
ClosedPublic

Authored by aklapper on May 17 2024, 08:58.
Tags
None
Referenced Files
F3531950: D25654.1744886720.diff
Wed, Apr 16, 10:45
F3531066: D25654.1744879188.diff
Wed, Apr 16, 08:39
F3433295: D25654.1744670314.diff
Sun, Apr 13, 22:38
F3391359: D25654.1744479277.diff
Fri, Apr 11, 17:34
F3385854: D25654.1744423526.diff
Fri, Apr 11, 02:05
F3372332: D25654.1744249542.diff
Wed, Apr 9, 01:45
F3368737: D25654.1744210856.diff
Tue, Apr 8, 15:00
F3361085: D25654.1744017059.diff
Sun, Apr 6, 09:10

Details

Summary

The PHPDoc for the abstract function loadObject() defines @return void, however the function's return value is used twice in PhabricatorObjectMailReceiver and all 17 loadObject() implementations in child classes return an object provided by some type of PhabricatorCursorPagedPolicyAwareQuery.
Thus correct the PHPDoc to make static code analyzers happier.

Test Plan

Carefully read and compare the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable