Page MenuHomePhorge

Correct call to non-existing PhutilFileLockException in support/unit/lock.php
ClosedPublic

Authored by aklapper on May 16 2024, 08:53.
Tags
None
Referenced Files
F4069159: D25641.1746828856.diff
Thu, May 8, 22:14
F4011446: D25641.1746625970.diff
Tue, May 6, 13:52
F3999876: D25641.1746612790.diff
Tue, May 6, 10:13
F3966757: D25641.1746516952.diff
Mon, May 5, 07:35
F3712114: D25641.1745673018.diff
Fri, Apr 25, 13:10
F3620909: D25641.1745312306.diff
Mon, Apr 21, 08:58
F3521329: D25641.1744815063.diff
Tue, Apr 15, 14:51
F3383997: D25641.1744397683.diff
Thu, Apr 10, 18:54

Details

Summary

PhutilFileLockException does not exist. Per https://we.phorge.it/source/arcanist/browse/master/src/filesystem/PhutilFileLock.php$54-66 , if lock acquisition fails it is supposed to throw a PhutilLockException instead.

Test Plan

Grep the code base.

Or, run this, from arcanist, from two different terminals:

php ./support/unit/lock.php asd.txt

After this change, the exception is correctly managed.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable