Page MenuHomePhorge

Correct call to non-existing PhutilFileLockException in support/unit/lock.php
ClosedPublic

Authored by aklapper on May 16 2024, 08:53.

Details

Summary

PhutilFileLockException does not exist. Per https://we.phorge.it/source/arcanist/browse/master/src/filesystem/PhutilFileLock.php$54-66 , if lock acquisition fails it is supposed to throw a PhutilLockException instead.

Test Plan

Grep the code base.

Or, run this, from arcanist, from two different terminals:

php ./support/unit/lock.php asd.txt

After this change, the exception is correctly managed.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable