Page MenuHomePhorge
Differential D25662

MimeMailParser: Remove an unused variable
AbandonedPublic
Actions

Authored by aklapper on May 18 2024, 07:41.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Summary

$parts is not used anywhere.

Test Plan

Carefully read the code.

Diff Detail

Repository
rP Phorge
Branch
mimemailparserUnusedVar (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1286
Build 1286: arc lint + arc unit

Event Timeline

aklapper created this revision.May 18 2024, 07:41
Owners added a reviewer: O1: Blessed Committers.May 18 2024, 07:41
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 18 2024, 07:41
aklapper requested review of this revision.May 18 2024, 07:41
Harbormaster completed remote builds in B1286: Diff 2018.May 18 2024, 07:41
valerio.bozzolan requested changes to this revision.May 18 2024, 12:56

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

This revision now requires changes to proceed.May 18 2024, 12:56
aklapper abandoned this revision.May 18 2024, 19:49

I'm stupid and should have really checked the commit history first. Sorry!

valerio.bozzolan awarded a token.May 18 2024, 19:50

Revision Contents
Changeset List

PathSizePackages
externals/
mimemailparser/
5 linesO1: Blessed Committers

Diff 2018

View Options

externals/mimemailparser/MimeMailParser.class.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0