Page MenuHomePhorge

Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver
ClosedPublic

Authored by aklapper on May 17 2024, 08:58.
Tags
None
Referenced Files
F2944554: D25654.1738273079.diff
Wed, Jan 29, 21:37
F2936924: D25654.1737943461.diff
Sun, Jan 26, 02:04
F2934398: D25654.1737786516.diff
Fri, Jan 24, 06:28
F2934373: D25654.1737785495.diff
Fri, Jan 24, 06:11
F2934372: D25654.1737785494.diff
Fri, Jan 24, 06:11
F2934369: D25654.1737785439.diff
Fri, Jan 24, 06:10
F2933019: D25654.1737750934.diff
Thu, Jan 23, 20:35
F2933017: D25654.1737750932.diff
Thu, Jan 23, 20:35

Details

Summary

The PHPDoc for the abstract function loadObject() defines @return void, however the function's return value is used twice in PhabricatorObjectMailReceiver and all 17 loadObject() implementations in child classes return an object provided by some type of PhabricatorCursorPagedPolicyAwareQuery.
Thus correct the PHPDoc to make static code analyzers happier.

Test Plan

Carefully read and compare the code.

Diff Detail

Repository
rP Phorge
Branch
mailReceiverObjectVoid (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1277
Build 1277: arc lint + arc unit