Page MenuHomePhorge

Correct PHPDoc or add default return for numerous methods
ClosedPublic

Authored by aklapper on May 16 2024, 14:42.

Details

Summary

Correct PHPDoc when none of the method calls try to handle a return value.
Add missing fallback return statements (which may never be reached if previous condition checks were always true).

This reduces the amount of errors reported by static code analysis tools.

Test Plan

Carefully read the code and check all places in which a function gets called whether a return value is expected.

Diff Detail

Repository
rP Phorge
Branch
fixMiscReturnValues (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1272
Build 1272: arc lint + arc unit