PhabricatorIconSet::getIcons() calls $this->newIcons() which is undefined.
As all six child classes which extend PhabricatorIconSet implement newIcons(), declare an abstract function in their parent class.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP98884f758a29: Fix call to non-existing newIcons() in PhabricatorIconSet
Carefully read the code.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- NEiconSetNewIcons (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1268 Build 1268: arc lint + arc unit
Event Timeline
Comment Actions
$ grep -FR 'extends PhabricatorIconSet' . ./src/applications/people/icon/PhabricatorPeopleIconSet.php: extends PhabricatorIconSet { ./src/applications/calendar/icon/PhabricatorCalendarIconSet.php: extends PhabricatorIconSet { ./src/applications/project/icon/PhabricatorProjectIconSet.php: extends PhabricatorIconSet { ./src/applications/badges/icon/PhabricatorBadgesIconSet.php: extends PhabricatorIconSet { ./src/applications/search/menuitem/PhabricatorProfileMenuItemIconSet.php: extends PhabricatorIconSet { ./src/applications/dashboard/icon/PhabricatorDashboardIconSet.php: extends PhabricatorIconSet { $ grep -FR 'function newIcons()' . ./src/applications/people/icon/PhabricatorPeopleIconSet.php: protected function newIcons() { ./src/applications/calendar/icon/PhabricatorCalendarIconSet.php: protected function newIcons() { ./src/applications/project/icon/PhabricatorProjectIconSet.php: protected function newIcons() { ./src/applications/badges/icon/PhabricatorBadgesIconSet.php: protected function newIcons() { ./src/applications/search/menuitem/PhabricatorProfileMenuItemIconSet.php: protected function newIcons() { ./src/applications/dashboard/icon/PhabricatorDashboardIconSet.php: protected function newIcons() {