Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck
ClosedPublic

Authored by aklapper on May 10 2024, 10:22.
Tags
None
Referenced Files
F3216820: D25633.1741716473.diff
Mon, Mar 10, 18:07
F3052324: D25633.1740986030.diff
Sun, Mar 2, 07:13
F3010074: D25633.1740627825.diff
Wed, Feb 26, 03:43
F3010069: D25633.1740627816.diff
Wed, Feb 26, 03:43
F3010062: D25633.1740627527.diff
Wed, Feb 26, 03:38
F3010051: D25633.1740626862.diff
Wed, Feb 26, 03:27
F2998417: D25633.1740412639.diff
Sun, Feb 23, 15:57
F2996801: D25633.1740386296.diff
Sun, Feb 23, 08:38

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/config/check/PhabricatorSetupCheck.php:125]

Closes T15823

Test Plan

Run ./bin/cache purge --all, check any Phorge page in browser before and after applying this patch.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable