Paths

Table of Contentst

Differential D25632

Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type
ClosedPublic
Actions

Authored by aklapper on May 10 2024, 10:04.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24

Commits

rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type

Summary

When the Content-Type HTTP header is empty or missing, null is passed to preg_match() which is deprecated behavior since PHP 8.1. Thus only call preg_match() when the value is set.

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [$HOME/arcanist/src/future/http/status/HTTPFutureHTTPResponseStatus.php:24]

Closes T15821

Test Plan

Visit something using HTTPFutureHTTPResponseStatus, like, a profile image. No crashes.

Diff Detail

Repository

Branch

strlenT15821 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1247
Build 1247: arc lint + arc unit

Event Timeline

aklapper created this revision.May 10 2024, 10:04

Owners added a reviewer: O1: Blessed Committers.May 10 2024, 10:04

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 10 2024, 10:04

aklapper requested review of this revision.May 10 2024, 10:04

Harbormaster completed remote builds in B1247: Diff 1969.May 10 2024, 10:04

Thanks! I was able to test visiting a profile image, and inspecting phlog() in the webserver log.

yesyes

This revision is now accepted and ready to land.May 10 2024, 12:58

valerio.bozzolan edited the test plan for this revision. (Show Details)May 10 2024, 12:59

Closed by commit rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type. · Explain WhyMay 10 2024, 16:13

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.

Revision Contents
Changeset List

Path

Size

Packages

src/

future/

http/

status/

HTTPFutureHTTPResponseStatus.php

3 lines

O1: Blessed Committers

Diff 1969

src/future/http/status/HTTPFutureHTTPResponseStatus.php

Loading...