Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 09:05.
Tags
None
Referenced Files
F2198125: D25592.1716316672.diff
Mon, May 20, 18:37
Unknown Object (File)
Sat, Apr 27, 05:45
Unknown Object (File)
Sat, Apr 27, 04:13
Unknown Object (File)
Sat, Apr 27, 03:28
Unknown Object (File)
Sat, Apr 27, 02:06
Unknown Object (File)
Fri, Apr 26, 20:12
Unknown Object (File)
Thu, Apr 25, 04:55
Unknown Object (File)
Wed, Apr 24, 17:04

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes two similar strlen() occurrences in the same source file.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php:62]
Test Plan

Run ../phorge/bin/storage renamespace: Get no strlen() error anymore but only expected output Usage Exception: Specify the dumpfile to read with "--input", or use "--live" to generate one automatically.

Diff Detail

Repository
rP Phorge
Branch
cliStorageRenamespaceStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1184
Build 1184: arc lint + arc unit