Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:41.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 01:57
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Tue, Apr 30, 15:46
Unknown Object (File)
Tue, Apr 30, 14:04
Unknown Object (File)
Sat, Apr 27, 05:30
Unknown Object (File)
Fri, Apr 26, 18:48

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes two similar strlen() occurrences in the same source file.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conduit/management/PhabricatorConduitCallManagementWorkflow.php:44]
Test Plan

Run ../phorge/bin/conduit call: Get no strlen() error anymore but only expected output Usage Exception: Specify a method to call with "--method".

Diff Detail

Repository
rP Phorge
Branch
cliConduitCallStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1176
Build 1176: arc lint + arc unit