Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:36.
Tags
None
Referenced Files
F3847256: D25583.1746105971.diff
Wed, Apr 30, 13:26
F3847254: D25583.1746105970.diff
Wed, Apr 30, 13:26
F3766853: D25583.1745847367.diff
Sun, Apr 27, 13:36
F3766852: D25583.1745847366.diff
Sun, Apr 27, 13:36
F3761217: D25583.1745830749.diff
Sun, Apr 27, 08:59
F3761216: D25583.1745830748.diff
Sun, Apr 27, 08:59
F3703984: D25583.1745631528.diff
Fri, Apr 25, 01:38
F3604660: D25583.1745219575.diff
Sun, Apr 20, 07:12

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php:37]
Test Plan

Run ../phorge/bin/auth refresh: Get no strlen() error anymore but only expected output Found 3 account(s) to refresh. (or similar)

Diff Detail

Repository
rP Phorge
Branch
cliAuthRefreshStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1175
Build 1175: arc lint + arc unit