Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:25.
Tags
None
Referenced Files
F2944597: D25581.1738273122.diff
Wed, Jan 29, 21:38
F2937038: D25581.1737945632.diff
Sun, Jan 26, 02:40
F2932815: D25581.1737744357.diff
Thu, Jan 23, 18:45
F2932814: D25581.1737744314.diff
Thu, Jan 23, 18:45
F2932812: D25581.1737744281.diff
Thu, Jan 23, 18:44
F2932728: D25581.1737743125.diff
Thu, Jan 23, 18:25
F2895939: D25581.1737238778.diff
Fri, Jan 17, 22:19
F2869249: D25581.1736698265.diff
Sat, Jan 11, 16:11

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:69]
Test Plan

Run ../phorge/bin/nuance update: Get no strlen() error anymore but only expected output Usage Exception: Specify a item with --item.

Diff Detail

Repository
rP Phorge
Branch
cliNuanceUpdateStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1173
Build 1173: arc lint + arc unit