The file name is a sufficient source of information, if available.
Closes T15729
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15729: Remarkup code blocks: guess the language from the "name" (if available)
- Commits
- rPb1ae1b1a6789: Remarkup code blocks: guess language from "name="
The new unit test is green. Old unit tests are green.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- remarkup-lang-guess-from-name
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1122 Build 1122: arc lint + arc unit
Event Timeline
| src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php | ||
|---|---|---|
| 157–159 | Better move this into the if (empty($options['lang']))) block below. | |
| src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php | ||
|---|---|---|
| 157–159 | (Premising that it was a feature - kind of waterfall attempt - since guessFilenameExtension() can return NULL) | |