Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined
ClosedPublic

Authored by aklapper on Mar 21 2024, 17:36.
Tags
None
Referenced Files
F3220946: D25556.1741813259.diff
Tue, Mar 11, 21:00
F3215749: D25556.1741660599.diff
Mon, Mar 10, 02:36
F3215748: D25556.1741660595.diff
Mon, Mar 10, 02:36
F3215747: D25556.1741660591.diff
Mon, Mar 10, 02:36
F3001542: D25556.1740443457.diff
Mon, Feb 24, 00:30
F3001541: D25556.1740443456.diff
Mon, Feb 24, 00:30
F2994673: D25556.1740324902.diff
Sat, Feb 22, 15:35
F2992599: D25556.1740231432.diff
Fri, Feb 21, 13:37

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/project/typeahead/PhabricatorProjectDatasource.php:99]

Closes T15761

Test Plan

Go to a task, enter # and start typing a project tag of a project which has no additional slugs defined.

Diff Detail

Repository
rP Phorge
Branch
T15761 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1114
Build 1114: arc lint + arc unit