Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined
ClosedPublic

Authored by aklapper on Mar 21 2024, 17:36.
Tags
None
Referenced Files
F2938949: D25556.1738026820.diff
Mon, Jan 27, 01:13
F2938948: D25556.1738026817.diff
Mon, Jan 27, 01:13
F2938847: D25556.1738024789.diff
Mon, Jan 27, 00:39
F2936298: D25556.1737911754.diff
Sat, Jan 25, 17:15
F2936297: D25556.1737911751.diff
Sat, Jan 25, 17:15
F2936296: D25556.1737911748.diff
Sat, Jan 25, 17:15
F2934743: D25556.1737801222.diff
Fri, Jan 24, 10:33
F2932351: D25556.1737733250.diff
Thu, Jan 23, 15:40

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/project/typeahead/PhabricatorProjectDatasource.php:99]

Closes T15761

Test Plan

Go to a task, enter # and start typing a project tag of a project which has no additional slugs defined.

Diff Detail

Repository
rP Phorge
Branch
T15761 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1114
Build 1114: arc lint + arc unit