Fix PHP 8.1 auth view strlen(null) error
ClosedPublic
Actions

Authored by Sten on Sep 5 2023, 14:16.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15634: auth view results in strlen(null) error under PHP 8.1

Commits

rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error

Summary

Trying to view a Jira auth provider from https://my.phorge.site/auth/ results in strlen(): Passing null to parameter #1 ($string) of type string is deprecated

This change fixes it

Fixes T15634

Test Plan

Go to https://my.phorge.site/auth/ and have a Jira already setup.
Click on Jira auth provider
Confirm the page is displayed and no error is generated.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Sep 5 2023, 14:16

Owners added a reviewer: O1: Blessed Committers.Sep 5 2023, 14:16

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 5 2023, 14:16

Sten requested review of this revision.Sep 5 2023, 14:16

Harbormaster completed remote builds in B830: Diff 1369.Sep 5 2023, 14:16

valerio.bozzolan edited the test plan for this revision. (Show Details)Sep 10 2023, 00:19

I tried to test this but I have not a real JIRA account and I was not able to test a non-null value. But, I inspected all the definitions of that method and it seems it only returns pht() so I would assume that it only returns strings.

This revision is now accepted and ready to land.Sep 10 2023, 00:27

Closed by commit rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error. · Explain WhySep 11 2023, 10:57

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.