Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1
Fixes T15635
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1
- Commits
- rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link
- Go into the Diviner differential page /book/phorge/article/differential/
- Click on the link to Differential User Guide: Inline Comments
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- diviner (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 831 Build 831: arc lint + arc unit
Event Timeline
Comment Actions
Thaaanks
The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that