Differential D25433

Fix Diviner strlen(null) error when clicking on a link
ClosedPublic
Actions

Authored by Sten on Sep 5 2023, 16:05.

Tags

None

Referenced Files

	F2945262: D25433.1738303829.diff
	Thu, Jan 30, 06:10

	F2941364: D25433.1738109418.diff
	Tue, Jan 28, 00:10

	F2938994: D25433.1738026864.diff
	Mon, Jan 27, 01:14

	F2938993: D25433.1738026864.diff
	Mon, Jan 27, 01:14

	F2938866: D25433.1738024807.diff
	Mon, Jan 27, 00:40

	F2934504: D25433.1737790915.diff
	Fri, Jan 24, 07:41

	F2932683: D25433.1737742454.diff
	Thu, Jan 23, 18:14

	F2932334: D25433.1737733234.diff
	Thu, Jan 23, 15:40

View All 11 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1

Commits

rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link

Summary

Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1

Fixes T15635

Test Plan

Go into the Diviner differential page /book/phorge/article/differential/
Click on the link to Differential User Guide: Inline Comments

Diff Detail

Repository

Branch

diviner (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 831
Build 831: arc lint + arc unit

Event Timeline

Sten created this revision.Sep 5 2023, 16:05

Owners added a reviewer: O1: Blessed Committers.Sep 5 2023, 16:05

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 5 2023, 16:05

Sten requested review of this revision.Sep 5 2023, 16:05

Harbormaster completed remote builds in B831: Diff 1370.Sep 5 2023, 16:05

Thaaanks

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

This revision is now accepted and ready to land.Sep 6 2023, 10:45

Closed by commit rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link. · Explain WhySep 6 2023, 11:23

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diviner/

controller/

DivinerFindController.php

2 lines

O1: Blessed Committers

Diff 1370

src/applications/diviner/controller/DivinerFindController.php

Loading...