Page MenuHomePhorge

Have more consistent getPlaceholderText() string formats
Open, Needs TriagePublic

Description

See discussion in D25991. Some use quotation marks, some do not currently.

  • Probably convert all be pht('Type "%s"...', 'viewer()');style (with or without quotation marks, shrug).
  • Some could be more complete, e.g. instead of pht('Type a username or "none"...');, should be pht('Type a username or "none" or "viewer"...');
[acko@foo phorge (master $|u=)]$ grep -r " getPlaceholderText" -A1 . | grep "return pht" | grep "()"
./src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php-    return pht('Type "none()"...');
./src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchAnyFunctionDatasource.php-    return pht('Type "any()"...');
./src/applications/maniphest/typeahead/ManiphestTaskClosedStatusDatasource.php-    return pht('Type closed()...');
./src/applications/maniphest/typeahead/ManiphestTaskOpenStatusDatasource.php-    return pht('Type open()...');
./src/applications/people/typeahead/PhabricatorPeopleAnyOwnerDatasource.php-    return pht('Type "anyone()"...');
./src/applications/people/typeahead/PhabricatorViewerDatasource.php-    return pht('Type viewer()...');
./src/applications/project/typeahead/PhabricatorProjectLogicalOnlyDatasource.php-    return pht('Type only()...');
./src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php-    return pht('Type viewerprojects()...');
./src/applications/differential/typeahead/DifferentialRevisionClosedStatusDatasource.php-    return pht('Type closed()...');
./src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php-    return pht('Type viewer()...');
./src/applications/differential/typeahead/DifferentialRevisionOpenStatusDatasource.php-    return pht('Type open()...');
./src/applications/calendar/typeahead/PhabricatorCalendarInviteeViewerFunctionDatasource.php-    return pht('Type viewer()...');
./src/applications/maniphest/typeahead/ManiphestAssigneeDatasource.php-   return pht('Type a username or "none"...');