Suppresses verbose logging from PhutilLibraryMapBuilder; see D25017 for context
Details
Details
- Reviewers
speck avivey - Group Reviewers
O1: Blessed Committers
Ran locally and verified that debug messages are only emitted if --verbose is passed
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- change-log (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 43 Build 43: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for looking into this. I ended up submitting the initial simple change to fix fwrite vs. fprintf to upstream and discussing with epriestley he recommended to instead just remove the use of logging. I ended up making a larger change that also corrects the error-handling when running arc liberate. We can probably hold off on changes here and merge in changes from upstream -- https://secure.phabricator.com/D21718
Comment Actions
Looks like https://secure.phabricator.com/D21718 explicitly changed to always remove --quiet, so unless there's a new argument for it, this change is redundant.