add --verbose argument to ArcanistLiberateWorkflow
AbandonedPublic
Actions

Authored by roguelazer on Sep 6 2021, 19:46.

Details

Reviewers

speck
avivey

Group Reviewers

O1: Blessed Committers

Summary

Suppresses verbose logging from PhutilLibraryMapBuilder; see D25017 for context

Test Plan

Ran locally and verified that debug messages are only emitted if --verbose is passed

Diff Detail

Repository

rARC Arcanist

Branch

change-log (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 43
Build 43: arc lint + arc unit

Event Timeline

roguelazer created this revision.Sep 6 2021, 19:46

Owners added a reviewer: O1: Blessed Committers.Sep 6 2021, 19:46

Herald added subscribers: valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 6 2021, 19:46

roguelazer requested review of this revision.Sep 6 2021, 19:46

Harbormaster completed remote builds in B43: Diff 60.Sep 6 2021, 19:46

Thanks for looking into this. I ended up submitting the initial simple change to fix fwrite vs. fprintf to upstream and discussing with epriestley he recommended to instead just remove the use of logging. I ended up making a larger change that also corrects the error-handling when running arc liberate. We can probably hold off on changes here and merge in changes from upstream -- https://secure.phabricator.com/D21718

Cigaryno subscribed.Sep 21 2022, 19:12

Looks like https://secure.phabricator.com/D21718 explicitly changed to always remove --quiet, so unless there's a new argument for it, this change is redundant.

This revision now requires changes to proceed.Sep 27 2022, 15:52

roguelazer abandoned this revision.Sep 27 2022, 16:27