Page MenuHomePhorge

add --verbose argument to ArcanistLiberateWorkflow
AbandonedPublic

Authored by roguelazer on Sep 6 2021, 19:46.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 22, 04:05
Unknown Object (File)
Mon, Jul 22, 03:27
Unknown Object (File)
Mon, Jul 22, 03:09
Unknown Object (File)
Tue, Jul 16, 03:35
Unknown Object (File)
Sat, Jul 13, 09:50
Unknown Object (File)
Sat, Jul 13, 09:50
Unknown Object (File)
Sat, Jul 13, 00:30
Unknown Object (File)
Fri, Jul 12, 23:38

Details

Reviewers
speck
avivey
Group Reviewers
O1: Blessed Committers
Summary

Suppresses verbose logging from PhutilLibraryMapBuilder; see D25017 for context

Test Plan

Ran locally and verified that debug messages are only emitted if --verbose is passed

Diff Detail

Repository
rARC Arcanist
Branch
change-log (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 43
Build 43: arc lint + arc unit

Event Timeline

Thanks for looking into this. I ended up submitting the initial simple change to fix fwrite vs. fprintf to upstream and discussing with epriestley he recommended to instead just remove the use of logging. I ended up making a larger change that also corrects the error-handling when running arc liberate. We can probably hold off on changes here and merge in changes from upstream -- https://secure.phabricator.com/D21718

avivey requested changes to this revision.Sep 27 2022, 15:52
avivey subscribed.

Looks like https://secure.phabricator.com/D21718 explicitly changed to always remove --quiet, so unless there's a new argument for it, this change is redundant.

This revision now requires changes to proceed.Sep 27 2022, 15:52