Paths

Table of Contentst

Fix call to non-existing newError() in PhabricatorEditorExtension
Needs ReviewPublic
Actions

Authored by aklapper on Thu, May 16, 10:07.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 1, 02:42

	Unknown Object (File)
	Wed, May 22, 23:45

	Unknown Object (File)
	Wed, May 22, 22:38

	Unknown Object (File)
	Wed, May 22, 21:51

	Unknown Object (File)
	Tue, May 21, 17:01

	Unknown Object (File)
	Sun, May 19, 20:01

	Unknown Object (File)
	Sat, May 18, 15:59

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

PhabricatorEditorExtension does not define a newError() method. Thus call existing newTransactionError() instead.
Also fix the typo in the function name (this function does not seem to get called anywhere anyway.)

Test Plan

Carefully read the code.

Diff Detail

Repository

rP Phorge

Branch

NEeditorExtensionNewError (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1264
Build 1264: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, May 16, 10:07

Owners added a reviewer: O1: Blessed Committers.Thu, May 16, 10:07

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 16, 10:07

aklapper requested review of this revision.Thu, May 16, 10:07

Harbormaster completed remote builds in B1264: Diff 1994.Thu, May 16, 10:07

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

transactions/

engineextension/

PhabricatorEditorExtension.php

4 lines

O1: Blessed Committers

Diff 1994

View Options

src/applications/transactions/engineextension/PhabricatorEditorExtension.php

Fix call to non-existing newError() in PhabricatorEditorExtensionNeeds ReviewPublicActions