Page MenuHomePhorge
Feed Advanced Search

Yesterday

mainframe98 accepted D26092: Fix return value of ArcanistWeldWorkflow::runWorkflow().
Sun, Jun 15, 19:56
mainframe98 accepted D26091: Remove remaining calls to discontinued APC.
Sun, Jun 15, 12:09
mainframe98 requested changes to D26092: Fix return value of ArcanistWeldWorkflow::runWorkflow().
Sun, Jun 15, 12:07
mainframe98 accepted D26093: Fix return values in PhutilKeyValueCacheStack.
Sun, Jun 15, 12:05
mainframe98 accepted D26094: Add PHP error constant for CURLE_SSL_CACERT_BADFILE.
Sun, Jun 15, 12:04
mainframe98 accepted D26087: Allow admins to edit email addresses of mailing list accounts again.

Tested as part of D26090, which should land after this but I couldn't find a way to stack then without arc wanting to steal this diff.

Sun, Jun 15, 08:35
mainframe98 requested review of D26090: Allow admins to edit email addresses of bot accounts.
Sun, Jun 15, 08:33
mainframe98 added a revision to T16111: Cannot change email address of bot account: D26090: Allow admins to edit email addresses of bot accounts.
Sun, Jun 15, 08:33
mainframe98 added a comment to T16111: Cannot change email address of bot account.

Given that supporting this is basically adding $this-getUser()->getIsSystemAgent() to PhabricatorEmailAddressesSettingsPanel in isManagementPanel (similar to how it's done in D26087), I don't see why we wouldn't do this. Sure, it's rather unlikely that you'll need to change the email address after creation, but the documentation on /people/new/bot/ states that they can interact with other systems which require an email address. It's not outside the realm of possibilities that the associated email address might need to change, and requiring manually editing the database while we have a perfectly good panel for it seems just silly.

Sun, Jun 15, 08:17
mainframe98 accepted D26086: Fix some invalid PhpDoc.

Some of these array type hints feel sketchy, but they already were unusual. I suppose this is fine. The rest certainly is.

Sun, Jun 15, 08:02
mainframe98 added inline comments to D26088: Improve passing false|null to some strlen() calls.
Sun, Jun 15, 08:01
mainframe98 accepted D26089: Correct boolean parameter of stream_set_blocking calls.
Sun, Jun 15, 06:43