Page MenuHomePhorge
Feed Advanced Search

Sun, Mar 30

aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

Why would a cancel URI be needed?

Sun, Mar 30, 22:04 · Security, User-Cigaryno
Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

After these steps I get Unhandled Exception ("Exception"): This transaction group requires MFA to apply, but the Editor was not configured with a Cancel URI. This workflow can not perform an MFA check.

Why would a cancel URI be needed? Do you know a Cancel URI for an app with something that prompts for MFA (ie. exposing Passphrases, empowering users, signing comments with MFA, managing your VCS password and SSH keys)

Sun, Mar 30, 20:51 · Security, User-Cigaryno
aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

That's what I tested (as the Files application can be uninstalled). Which exact application(s) did you test?
I'm surprised that you did not run into the same problem as I did described in my last comment...maybe it's related to not being an admin?

Sun, Mar 30, 20:46 · Security, User-Cigaryno
Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

As which type of user?

A user with the Can Configure Application capability (by default admins).

Sun, Mar 30, 20:31 · Security, User-Cigaryno
aklapper requested changes to D25935: Require MFA to uninstall apps if enabled.

Clear Test Plans with URIs are welcome - the less others need to think "how/where to do that" the easier gets testing.

Sun, Mar 30, 20:13 · Security, User-Cigaryno

Sat, Mar 29

Cigaryno claimed T15490: Uninstalling/Installing an application should eventually involve MFA.

I don't know if what I done on D25935 is correct, but as usual, Request Changes if I did it wrong.
I relied on the code on PhabricatorUserEmpowerTransaction to try to make PhabricatorApplicationUninstallTransaction require MFA if enabled.

Sat, Mar 29, 16:52 · User-valerio.bozzolan, Security
Cigaryno updated the diff for D25935: Require MFA to uninstall apps if enabled.

Make lint happy

Sat, Mar 29, 16:43 · Security, User-Cigaryno
Cigaryno requested review of D25935: Require MFA to uninstall apps if enabled.
Sat, Mar 29, 16:40 · Security, User-Cigaryno
Cigaryno added a revision to T15490: Uninstalling/Installing an application should eventually involve MFA: D25935: Require MFA to uninstall apps if enabled.
Sat, Mar 29, 16:40 · User-valerio.bozzolan, Security