Page MenuHomePhorge

Rebuild quickstart.sql
Needs ReviewPublic

Authored by mainframe98 on Thu, Feb 27, 18:42.
Tags
None
Referenced Files
F3292949: D25899.1742902844.diff
Mon, Mar 24, 11:40
F3253774: D25899.1742442215.diff
Wed, Mar 19, 03:43
F3250115: D25899.1742295884.diff
Mon, Mar 17, 11:04
F3224485: D25899.1742043563.diff
Fri, Mar 14, 12:59
F3224342: D25899.1742018284.diff
Fri, Mar 14, 05:58
F3216889: D25899.1741719297.diff
Mon, Mar 10, 18:54
F3216357: D25899.1741693005.diff
Mon, Mar 10, 11:36
F3215812: D25899.1741663781.diff
Mon, Mar 10, 03:29

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

This requires some modifications:

  • Remove all migrations for releeph and phragment. These are referring to objects and tables that do not exist in modern Phorge installations and cannot run.
  • Remove the paste mail key generation. New code will set this correctly, and old installations that didn't apply this change have other concerns. In a follow up, migrating these to the mail table will make it obsolete anyways.
  • Modify the 20131205.buildtargets.sql migration to modify the index before dropping the column that the index uses, as MariaDB refuses to drop a column used in an index.

In addition, to make sure the diff for quickstart.sql isn't
unreviewable, sort databases and tables alphabetically in the dump
script.

All in all, this results in a quickstart.sql that is better rebuildable.
For some reason, this drops certain explicit collation and character
set statements. This should not have any effect, as the table creation
statement already states the same. The explicit SET character_client_set
and SET NAMES statements appeared during the last rebuild in
5720a38cfe95. They weren't emitted previously.

Test Plan

Without this patch:

  • Run ./bin/storage quickstart without this patch
  • Observe exceptions regarding missing releeph, phragment and pastebin databases
  • Cleanup phabricator_quickstart_* databases that weren't removed

With this patch:

  • Run ./bin/storage quickstart --output resources/sql/quickstart.sql
  • Observe quickstart.sql is updated

Diff Detail

Repository
rP Phorge
Branch
quickstart
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningresources/sql/quickstart.sql:5564TXT3Line Too Long
Warningresources/sql/quickstart.sql:5565TXT3Line Too Long
Warningresources/sql/quickstart.sql:6737TXT3Line Too Long
Warningresources/sql/quickstart.sql:6811TXT3Line Too Long
Warningresources/sql/quickstart.sql:6812TXT3Line Too Long
Warningresources/sql/quickstart.sql:6813TXT3Line Too Long
Warningresources/sql/quickstart.sql:7408TXT3Line Too Long
Warningresources/sql/quickstart.sql:8799TXT3Line Too Long
Warningresources/sql/quickstart.sql:10139TXT3Line Too Long
Warningresources/sql/quickstart.sql:10140TXT3Line Too Long
Warningresources/sql/quickstart.sql:10141TXT3Line Too Long
Warningresources/sql/quickstart.sql:10142TXT3Line Too Long
Warningresources/sql/quickstart.sql:10143TXT3Line Too Long
Warningresources/sql/quickstart.sql:10144TXT3Line Too Long
Warningresources/sql/quickstart.sql:10232TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 1751
Build 1751: arc lint + arc unit