Skip writing symbol cache to non-writable directories
Needs RevisionPublic
Actions

Authored by xtex on Feb 11 2025, 03:22.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

As the title, this makes it possible to install arcanist to
non-writable paths, for example, when installing arcanist with system
package managers.

Test Plan

Put arcanist to /usr/lib/arcanist (:

Diff Detail

Repository

rARC Arcanist

Branch

fix-cache

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 1692
Build 1692: arc lint + arc unit

Event Timeline

xtex created this revision.Feb 11 2025, 03:22

Owners added a reviewer: O1: Blessed Committers.Feb 11 2025, 03:22

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 11 2025, 03:22

xtex requested review of this revision.Feb 11 2025, 03:22

Harbormaster completed remote builds in B1692: Diff 2629.Feb 11 2025, 03:22

(1. Are you an heroic package manager? <3 nice to know!)

Are you using arc liberate as test plan? Maybe we can mention it. So I think you get this exception:

[2025-02-11 06:39:39] EXCEPTION: (FilesystemException) Requested path '/usr/lib/arcanist/src/__phutil_library_map__.php' is not writable. at [<arcanist>/src/filesystem/Filesystem.php:1288]

In case, probably it's better to package Arcanist only after the command arc liberate was executed successfully with sufficient write permissions. Then, later calls should probably not auto-trigger it - if I remember correctly.

What do you think about? Thaanks :)

( I was running arc lint in phorge.git and got the same error.
Thank u for your recommendation of running arc liberate. Will add that to packaging script :)