Differential D25756

fix PHP8 array_slice($results, null) which cause diffusion pattern search broken
ClosedPublic
Actions

Authored by gemini133 on Jul 30 2024, 01:53.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP721d5ed64b70: fix PHP8 array_slice($results, null) which cause diffusion pattern search broken

Test Plan

check diffusion pattern search if working

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gemini133 created this revision.Jul 30 2024, 01:53

Owners added a reviewer: O1: Blessed Committers.Jul 30 2024, 01:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 30 2024, 01:53

gemini133 requested review of this revision.Jul 30 2024, 01:53

Harbormaster completed remote builds in B1475: Diff 2297.Jul 30 2024, 01:53

follow @valerio.bozzolan what suggested at https://we.phorge.it/D25750#20386.
we barely used pattern search but it indeed was broken.
with this fix, it works.

will submit another diff resolving the strlen problem accroding to @valerio.bozzolan

sgtm

This revision is now accepted and ready to land.Jul 30 2024, 06:36

Closed by commit rP721d5ed64b70: fix PHP8 array_slice($results, null) which cause diffusion pattern search broken. · Explain WhyJul 31 2024, 01:51

This revision was automatically updated to reflect the committed changes.

gemini133 added a commit: rP721d5ed64b70: fix PHP8 array_slice($results, null) which cause diffusion pattern search broken.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

conduit/

DiffusionSearchQueryConduitAPIMethod.php

2 lines

O1: Blessed Committers

Diff 2303

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

Loading...