Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Today

aklapper added a comment to T15048: Allow awarding Tokens to individual Comments.

@20after4: Willing to share some code at some point that folks can poke or play with? :) TIA!

Sun, May 19, 19:54 · Comments

aklapper awarded T15048: Allow awarding Tokens to individual Comments a Love token.

Sun, May 19, 19:46 · Comments

aklapper closed T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.

Sun, May 19, 11:10 · PHP 8 support

aklapper closed T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0 as Resolved by committing rPa579a974ebfe: PHPMailer: Remove use of each() function removed in PHP 8.0.

Sun, May 19, 11:10 · PHP 8 support

aklapper closed D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Sun, May 19, 11:10

aklapper committed rPa579a974ebfe: PHPMailer: Remove use of each() function removed in PHP 8.0.

PHPMailer: Remove use of each() function removed in PHP 8.0

Sun, May 19, 11:10

aklapper updated the test plan for D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Sun, May 19, 10:37

aklapper closed D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Sun, May 19, 08:28

aklapper committed rARC3cb117684f4e: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath

Sun, May 19, 08:28

aklapper closed D25663: PHPMailer: Remove check for non-existing get_magic_quotes().

Sun, May 19, 08:20

aklapper committed rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes().

PHPMailer: Remove check for non-existing get_magic_quotes()

Sun, May 19, 08:20

aklapper retitled D25663: PHPMailer: Remove check for non-existing get_magic_quotes() from PHPMailer: Remove check for non-existing `get_magic_quotes`

Sun, May 19, 08:19

avivey added a project to T15835: Misc "Return type is not covariant" errors for method Iterator::key(): PHP 8 support.

Sun, May 19, 06:12 · PHP 8 support

avivey updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().

Sun, May 19, 06:11 · PHP 8 support

avivey accepted D25663: PHPMailer: Remove check for non-existing get_magic_quotes().

Sun, May 19, 06:06

valerio.bozzolan accepted D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Thanks asd

Sun, May 19, 05:11

Yesterday

aklapper updated the summary of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Sat, May 18, 23:24

aklapper updated the diff for D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Valerio may have a point here :D

Sat, May 18, 23:23

aklapper requested review of D25663: PHPMailer: Remove check for non-existing get_magic_quotes().

Sat, May 18, 23:12

aklapper created T15836: ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList.

Sat, May 18, 22:37

aklapper updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().

Sat, May 18, 22:25 · PHP 8 support

aklapper created T15835: Misc "Return type is not covariant" errors for method Iterator::key().

Sat, May 18, 22:20 · PHP 8 support

aklapper closed D25650: Correct PHPDoc or add default return for numerous methods.

Sat, May 18, 19:54

aklapper committed rPc1a8b83bd7ea: Correct PHPDoc or add default return for numerous methods.

Correct PHPDoc or add default return for numerous methods

Sat, May 18, 19:54

valerio.bozzolan awarded D25662: MimeMailParser: Remove an unused variable a Love token.

Sat, May 18, 19:50

aklapper abandoned D25662: MimeMailParser: Remove an unused variable.

I'm stupid and should have really checked the commit history first. Sorry!

Sat, May 18, 19:49

aklapper closed D25651: Fix typo creating QRbitstream().

Sat, May 18, 19:45

aklapper committed rP23a3f59be227: Fix typo creating QRbitstream().

Fix typo creating QRbitstream()

Sat, May 18, 19:45

aklapper added a comment to D25651: Fix typo creating QRbitstream().

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

Sat, May 18, 19:43

aklapper closed D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

Sat, May 18, 19:41

aklapper committed rP8c8211787894: Fix PonderQuestionCreateMailReceiver accessing non-existing….

Fix PonderQuestionCreateMailReceiver accessing non-existing…

Sat, May 18, 19:41

aklapper updated the test plan for D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

Sat, May 18, 19:39

aklapper closed D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.

Sat, May 18, 19:39

aklapper committed rARC5477568274e3: Correct call to non-existing Filesystem::removePath() in….

Correct call to non-existing Filesystem::removePath() in…

Sat, May 18, 19:39

valerio.bozzolan created E39: Valerio available (vacation).

Sat, May 18, 19:32

valerio.bozzolan updated the summary of D25651: Fix typo creating QRbitstream().

Sat, May 18, 19:30

valerio.bozzolan updated the diff for D25651: Fix typo creating QRbitstream().

shot at line 1162

Sat, May 18, 19:29

valerio.bozzolan accepted D25651: Fix typo creating QRbitstream().

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

Sat, May 18, 19:26

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 18:55

valerio.bozzolan accepted D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

I tested this with the following snippet:

Sat, May 18, 18:51

valerio.bozzolan requested changes to D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Sat, May 18, 13:33

valerio.bozzolan accepted D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

Sat, May 18, 13:17

valerio.bozzolan accepted D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.

It was probably confused with the internal API executeRemovePath

Sat, May 18, 13:08

valerio.bozzolan requested changes to D25662: MimeMailParser: Remove an unused variable.

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

Sat, May 18, 12:56

valerio.bozzolan edited the content of 2024 week 19.

Sat, May 18, 12:52

mainframe98 awarded D25626: The feed "created this task" should be the first one a Love token.

Sat, May 18, 08:54

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 08:35

valerio.bozzolan accepted D25549: Add Standard Custom Fields to Item List.

Uh! I like this.

Sat, May 18, 08:35

valerio.bozzolan closed D25080: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Sat, May 18, 08:16 · Workboard

valerio.bozzolan closed T15162: Workboard Trigger Rule: allow to Add/Remove Subscribers as Resolved by committing rPb8a03bc145b1: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Sat, May 18, 08:16 · User-valerio.bozzolan, Trigger, Workboard

valerio.bozzolan committed rPb8a03bc145b1: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Workboard Trigger Rule: allow to Add/Remove Subscribers

Sat, May 18, 08:16

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 08:15

valerio.bozzolan added a parent task for T15133: Differential List View should show Repository: T15750: Integrate CustomField into more interfaces.

Sat, May 18, 08:14 · Differential

valerio.bozzolan added a subtask for T15750: Integrate CustomField into more interfaces: T15133: Differential List View should show Repository.

Sat, May 18, 08:14

valerio.bozzolan closed T15816: The feed "created this task" should be the first one as Resolved.

Probably OK now

Sat, May 18, 08:10 · Bug Reports, User-valerio.bozzolan

valerio.bozzolan edited the content of Template.

Sat, May 18, 08:08

valerio.bozzolan closed D25626: The feed "created this task" should be the first one.

Sat, May 18, 08:05

valerio.bozzolan committed rPf4d9d6920bcd: The feed "created this task" should be the first one.

The feed "created this task" should be the first one

Sat, May 18, 08:05

aklapper requested review of D25662: MimeMailParser: Remove an unused variable.

Sat, May 18, 07:41

aklapper added a comment to D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.

Sat, May 18, 06:44

aklapper added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.

Sat, May 18, 06:28

valerio.bozzolan added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.

Sat, May 18, 05:30

aklapper closed D25661: PHPMailer: Remove a check for PHP 5.0.

Sat, May 18, 00:00

aklapper committed rPa6499aee0ef4: PHPMailer: Remove a check for PHP 5.0.

PHPMailer: Remove a check for PHP 5.0

Sat, May 18, 00:00

Fri, May 17

speck accepted D25661: PHPMailer: Remove a check for PHP 5.0.

Fri, May 17, 17:57

aklapper updated the diff for D25661: PHPMailer: Remove a check for PHP 5.0.

Indentation is awesome

Fri, May 17, 14:21

aklapper requested review of D25661: PHPMailer: Remove a check for PHP 5.0.

Fri, May 17, 14:18

aklapper requested review of D25660: PHPMailer: Set defaults for required parameters followed by required parameters in Authorise() method signature.

Fri, May 17, 14:14

aklapper added a revision to T15834: Parameter order of Authorise() signature in phpmailer/class.pop3.php is deprecated since PHP 8.0: D25660: PHPMailer: Set defaults for required parameters followed by required parameters in Authorise() method signature.

Fri, May 17, 14:14 · PHP 8 support

aklapper requested review of D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Fri, May 17, 13:56

aklapper added a revision to T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0: D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Fri, May 17, 13:56 · PHP 8 support

aklapper requested review of D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

Fri, May 17, 13:13

aklapper created T15834: Parameter order of Authorise() signature in phpmailer/class.pop3.php is deprecated since PHP 8.0.

Fri, May 17, 10:10 · PHP 8 support

aklapper updated the task description for T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0.

Fri, May 17, 10:05 · PHP 8 support

aklapper created T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0.

Fri, May 17, 10:00 · PHP 8 support

aklapper requested review of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Fri, May 17, 09:47

aklapper requested review of D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

Fri, May 17, 09:21

aklapper requested review of D25655: Fix call to non-existing newWorkCommands() in NuanceItemType.

Fri, May 17, 09:09

aklapper requested review of D25654: Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver.

Fri, May 17, 08:58

aklapper requested review of D25653: Fix call to non-existing getDisplayName() in DiffusionRepositoryClusterEngine.php.

Fri, May 17, 08:28

valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.

Fri, May 17, 07:16

aklapper closed T15799: Reports tooltip hardcodes Maniphest Priority field names as Resolved by committing rPe6925c83c187: Do not hardcode default Priority names in Project Reports tooltip.

Fri, May 17, 07:16

aklapper closed D25602: Do not hardcode default Priority names in Project Reports tooltip.

Fri, May 17, 07:16

aklapper committed rPe6925c83c187: Do not hardcode default Priority names in Project Reports tooltip.

Do not hardcode default Priority names in Project Reports tooltip

Fri, May 17, 07:16

Thu, May 16

valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.

Thu, May 16, 20:11

aklapper updated the diff for D25602: Do not hardcode default Priority names in Project Reports tooltip.

Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)

Thu, May 16, 18:47

aklapper requested review of D25652: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine.

Thu, May 16, 15:29

aklapper added a comment to D25651: Fix typo creating QRbitstream().

It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.

Thu, May 16, 15:16

aklapper requested review of D25651: Fix typo creating QRbitstream().

Thu, May 16, 15:15

valerio.bozzolan accepted D25650: Correct PHPDoc or add default return for numerous methods.

Thu, May 16, 14:45

aklapper requested review of D25650: Correct PHPDoc or add default return for numerous methods.

Thu, May 16, 14:42

valerio.bozzolan awarded D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment a Love token.

Thu, May 16, 12:18

aklapper updated the diff for D25642: Initialize $cache_key variable in CelerityResourceController.php.

I felt it's not necessarily needed but it cannot hurt either. :)

Thu, May 16, 11:52

aklapper requested review of D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Thu, May 16, 11:28

aklapper requested review of D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.

Thu, May 16, 11:16

aklapper requested review of D25647: Fix call to non-existing newIcons() in PhabricatorIconSet.

Thu, May 16, 11:03

aklapper requested review of D25646: Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards.

Thu, May 16, 10:55

aklapper requested review of D25645: Fix call to non-existing Filesystem::digestForIndex() in PhabricatorUserCache.

Thu, May 16, 10:42

aklapper requested review of D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment.

Thu, May 16, 10:25

aklapper requested review of D25643: Fix call to non-existing newError() in PhabricatorEditorExtension.

Thu, May 16, 10:07